Changes

Page history
Update Review authored by NV Krishnendu's avatar NV Krishnendu
Show whitespace changes
Inline Side-by-side
Review.md
View page @ 5625c945
...@@ -46,12 +46,12 @@ This is the review page of the Modified Dispersion Relation test implementation ...@@ -46,12 +46,12 @@ This is the review page of the Modified Dispersion Relation test implementation
|--------|-------------------|--------|----------|---------|----------------| |--------|-------------------|--------|----------|---------|----------------|
| [conversion.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py) | Python script with useful conversion functions | Done | | | <br>Multiple reference to the same paper and Eqn, [here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L42) <br>Clean up [from here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L62) to [here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L85) | | [conversion.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py) | Python script with useful conversion functions | Done | | | <br>Multiple reference to the same paper and Eqn, [here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L42) <br>Clean up [from here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L62) to [here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L85) |
| [waveform.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/waveform.py) | Python script with Bibly compatible LIV waveform implementation | Done | `9bf21cb4` | | :heavy_check_mark: | | [waveform.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/waveform.py) | Python script with Bibly compatible LIV waveform implementation | Done | `9bf21cb4` | | :heavy_check_mark: |
| [**init**.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/\__init_\_.py) | Python initialization scipt | Done | | | | | [**init**.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/\__init_\_.py) | Python initialization scipt | Done | | `63e8cad5 ` | Looks fine <br> <br> Is the same file to beused in bilby_tgr? |
| [postprocessing.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/postprocessing.py) | Postprocessing PE results | | | | | | [postprocessing.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/postprocessing.py) | Postprocessing PE results | | | | |
| [prior.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/prior.py) | Default prior for MDR | | | | | | [prior.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/prior.py) | Default prior for MDR | | | |Looks fine |
| [conversion_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/conversion_test.py) | Unit test for conversion functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/conversion_test.txt) | | | | | | [conversion_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/conversion_test.py) | Unit test for conversion functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/conversion_test.txt) | | | 2222d319 for the file and efe1002e for the output| :heavy_check_mark:Looks fine |
| [source_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/source_test.py) | Unit test for source functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/source_test.txt) | | | | | | [source_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/source_test.py) | Unit test for source functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/source_test.txt) | | | efe1002e | :heavy_check_mark:Looks fine |
| [prior_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/prior_test.py.py) | Unit test for prior functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/prior_test.txt) | | | | | | [prior_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/prior_test.py.py) | Unit test for prior functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/prior_test.txt) | | | efe1002e for output?| could not find the prior file |
## Tests ## Tests
### 1. [Reproducing O3b results](https://git.ligo.org/tomasz.baka/liv-automation/-/wikis/O3b-Results/Summary) ### 1. [Reproducing O3b results](https://git.ligo.org/tomasz.baka/liv-automation/-/wikis/O3b-Results/Summary)
... ...
......