Skip to content

Changes

Page history
Update Review authored by Tomek Baka's avatar Tomek Baka
Show whitespace changes
Inline Side-by-side
Review.md
View page @ f7485486
......@@ -42,16 +42,16 @@ This is the review page of the Modified Dispersion Relation test implementation
:heavy_check_mark: means that the review is complete
| Script | Short description | Status | git hash | Comment | final sign-off |
|--------|-------------------|--------|----------|---------|----------------|
| [conversion.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py) | Python script with useful conversion functions | Done |`26462dc7` | | <br>Multiple reference to the same paper and Eqn, [here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L42) <br>Clean up [from here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L62) to [here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L85) **TB:** those are old comment. I think they were about comments not displaying well on gitlab code viewers (they look fine in other python code editors). Can you confirm if that was the problem mentioned? **Krishnendu** Yes, I agree <br><br> :heavy_check_mark: |
| [waveform.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/waveform.py) | Python script with Bibly compatible LIV waveform implementation | Done | `9bf21cb4` | | :heavy_check_mark: |
| [**init**.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/\__init_\_.py) | Python initialization scipt | Done | 63e8cad5 | :heavy_check_mark: | Looks fine <br> <br> Is the same file to beused in bilby_tgr? **TB:** we will need it for bilby_tgr (to import mdr submodule) <br> **Krishnendu** Okay|
| [postprocessing.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/postprocessing.py) | Postprocessing PE results | | | | |
| [prior.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/prior.py) | Default prior for MDR | | 8c0f6bbf | |Looks fine :heavy_check_mark: |
| [conversion_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/conversion_test.py) | Unit test for conversion functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/conversion_test.txt) | | 2222d319 for the file and efe1002e for the output| | :heavy_check_mark: Looks fine |
| [source_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/source_test.py) | Unit test for source functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/source_test.txt) | | efe1002e | | :heavy_check_mark: Looks fine |
| [prior_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/prior_test.py.py) | Unit test for prior functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/prior_test.txt) | | efe1002e for output? | | could not find the prior file **TB:** it appers I have made a mistake while linking to the output file. Balazs fixed the link now|
| Script | Short description | Status | git hash | Comment | final sign-off | Reviewer |
|--------|-------------------|--------|----------|---------|----------------| -------- |
| [conversion.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py) | Python script with useful conversion functions | Done |`26462dc7` | | <br>Multiple reference to the same paper and Eqn, [here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L42) <br>Clean up [from here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L62) to [here](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/conversion.py#L85) **TB:** those are old comment. I think they were about comments not displaying well on gitlab code viewers (they look fine in other python code editors). Can you confirm if that was the problem mentioned? **Krishnendu** Yes, I agree <br><br> :heavy_check_mark: | Krishnendu |
| [waveform.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/waveform.py) | Python script with Bibly compatible LIV waveform implementation | Done | `9bf21cb4` | | :heavy_check_mark: | Leila |
| [**init**.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/\__init_\_.py) | Python initialization scipt | Done | 63e8cad5 | :heavy_check_mark: | Looks fine <br> <br> Is the same file to beused in bilby_tgr? **TB:** we will need it for bilby_tgr (to import mdr submodule) <br> **Krishnendu** Okay| Krishnendu |
| [postprocessing.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/postprocessing.py) | Postprocessing PE results | | | | | |
| [prior.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/bilbyLIV/prior.py) | Default prior for MDR | | 8c0f6bbf | |Looks fine :heavy_check_mark: | Krishnendu |
| [conversion_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/conversion_test.py) | Unit test for conversion functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/conversion_test.txt) | | 2222d319 for the file and efe1002e for the output| | :heavy_check_mark: Looks fine | Krishnendu |
| [source_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/source_test.py) | Unit test for source functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/source_test.txt) | | efe1002e | | :heavy_check_mark: Looks fine | Krishnendu |
| [prior_test.py](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/prior_test.py.py) | Unit test for prior functions. [output](https://git.ligo.org/tomasz.baka/liv-automation/-/blob/main/review/prior_test.txt) | | efe1002e for output? | | could not find the prior file **TB:** it appers I have made a mistake while linking to the output file. Balazs fixed the link now | Krishnendu |
## Tests
### 1. [Reproducing O3b results](https://git.ligo.org/tomasz.baka/liv-automation/-/wikis/O3b-Results/Summary)
......