GWOLLUM writes XML files with invalid type for uint8
In files generated by @joseph.areeda, it looks like GWOLLUM (Omicron) is writing files with type "uint_8s"
, which is invalid. The correct type for UINT32 is "int_8u"
(the 's' meaning 'signed' and 'u' 'unsigned').
From ldas-pcdev1.ligo-la.caltech.edu
:
$ ligolw_print /home/detchar/joework/ligolw-test/L1-GDS_CALIB_STRAIN_OMICRON-1323748945-60.xml -t process_params | grep uint
process:process_id:0,OMICRON,uint_8s,omicron_DATA_SAMPLEFREQUENCY,16384
process:process_id:0,OMICRON,uint_8s,omicron_INJECTION_SG,0
process:process_id:0,OMICRON,uint_8s,omicron_PARAMETER_CHUNKDURATION,64
process:process_id:0,OMICRON,uint_8s,omicron_PARAMETER_OVERLAPDURATION,4
process:process_id:0,OMICRON,uint_8s,omicron_PARAMETER_PSDLENGTH,124
process:process_id:0,OMICRON,uint_8s,omicron_PARAMETER_TRIGGERBUFFERSIZE,0
process:process_id:0,OMICRON,uint_8s,omicron_OUTPUT_VERBOSITY,1
process:process_id:0,OMICRON,uint_8s,omicron_OUTPUT_PLOTWIDTH,0
process:process_id:0,OMICRON,uint_8s,omicron_OUTPUT_PLOTHEIGHT,0
I believe the following patch is sufficient to correct this:
diff --git a/src/Triggers/MakeTriggers.cc b/src/Triggers/MakeTriggers.cc
index 7ec29f0..cffe94a 100644
--- a/src/Triggers/MakeTriggers.cc
+++ b/src/Triggers/MakeTriggers.cc
@@ -545,7 +545,7 @@ void MakeTriggers::WriteXML(const string aFileName){
for(unsigned int m=0; m<metaname.size(); m++){
if(!metatype[m].compare("s")) xmlfile<<"\t\t\t\"process:process_id:0\",\""<<Mprocessname<<"\",\"lstring\",\""<<metaname[m]<<"\",\""<<Msvar[m]<<"\"";
else if(!metatype[m].compare("i")) xmlfile<<"\t\t\t\"process:process_id:0\",\""<<Mprocessname<<"\",\"int_8s\",\""<<metaname[m]<<"\",\""<<Mivar[m]<<"\"";
- else if(!metatype[m].compare("u")) xmlfile<<"\t\t\t\"process:process_id:0\",\""<<Mprocessname<<"\",\"uint_8s\",\""<<metaname[m]<<"\",\""<<Muvar[m]<<"\"";
+ else if(!metatype[m].compare("u")) xmlfile<<"\t\t\t\"process:process_id:0\",\""<<Mprocessname<<"\",\"int_8u\",\""<<metaname[m]<<"\",\""<<Muvar[m]<<"\"";
else xmlfile<<"\t\t\t\"process:process_id:0\",\""<<Mprocessname<<"\",\"real_8\",\""<<metaname[m]<<"\",\""<<Mdvar[m]<<"\"";
if(m!=metaname.size()-1) xmlfile<<","<<endl;
else xmlfile<<endl;