Skip to content

Modify the EPICS records for the O4 CALCS model and GDS

Evan Goetz requested to merge evan-goetz/pydarm:update-epics into master

This MR updates the EPICS records calculation in calcs.py and derived data products in uncertainty.py in order to conform to the O4 CALCS model updates for where the signals for d_err, x_sus, and x_pcal are read out. It was always so confusing in previous runs because CALCS and GDS did not read the same channels when computing TDCF values. In O4, both CALCS and GDS should now read channels only from the CALCS model, ameliorating this discrepancy.

Here I've modified the uncertainty calculations to update those calculations for the appropriate EPICS records, but really they should just use the EPICS records calculated by the calcs.py method. I'll save that for a different MR.

Requesting a broad review since this has impacts on CALCS and GDS TDCFs, and I'd like to make sure everyone is on the same page.

Edited by Evan Goetz

Merge request reports