Skip to content

Fix bug when ADC has an advance

Evan Goetz requested to merge evan-goetz/pydarm:fix-adc-advance into master

@joseph-betzwieser Pointed out in an email that using adc_delay_cycles < 0 results in a crash. This MR fixes the issue by handling negative cycles (advances) by using zeros instead of poles in the ZerosPolesGain of utils.digital_delay_filter().

A unit test has also been implemented to test this in the utils module and sensing module

Edited by Evan Goetz

Merge request reports