Skip to content
Snippets Groups Projects
Jacob Golomb's avatar
commented on merge request !104 "Add evidence to popsummary" at RatesAndPopulations / GWPopulation Pipe

oops, unmarked it

Colm Talbot's avatar
  • 36537b25 · Add evidence to popsummary
Colm Talbot's avatar
accepted merge request !104 "Add evidence to popsummary" at RatesAndPopulations / GWPopulation Pipe
Colm Talbot's avatar
commented on merge request !104 "Add evidence to popsummary" at RatesAndPopulations / GWPopulation Pipe

@jacob.golomb we're just waiting for this to be no marked as draft.

Jack Heinzel's avatar
approved merge request !104 "Add evidence to popsummary" at RatesAndPopulations / GWPopulation Pipe
Colm Talbot's avatar
commented on merge request !104 "Add evidence to popsummary" at RatesAndPopulations / GWPopulation Pipe

Looks good to me

Jacob Golomb's avatar
opened merge request !104 "Add evidence to popsummary" at RatesAndPopulations / GWPopulation Pipe
Colm Talbot's avatar
commented on merge request !102 "Draft: ENH: improve jitting of key functions" at RatesAndPopulations / GWPopulation Pipe

This breaks the rate construction for some reason, presumably something is being unsafely cached.

Colm Talbot's avatar
  • 68824f8f · Added model.prob before jitting
Colm Talbot's avatar
accepted merge request !103 "Added model.prob before jitting" at RatesAndPopulations / GWPopulation Pipe
Colm Talbot's avatar
commented on merge request !103 "Added model.prob before jitting" at RatesAndPopulations / GWPopulation Pipe

This looks good to me, I would count this as a user error for gwpopulation on our side.

Colm Talbot's avatar
approved merge request !103 "Added model.prob before jitting" at RatesAndPopulations / GWPopulation Pipe
Jacob Golomb's avatar
opened merge request !103 "Added model.prob before jitting" at RatesAndPopulations / GWPopulation Pipe
Jack Heinzel's avatar
commented on merge request !102 "Draft: ENH: improve jitting of key functions" at RatesAndPopulations / GWPopulation Pipe

Looks ok to me!

Jack Heinzel's avatar
approved merge request !102 "Draft: ENH: improve jitting of key functions" at RatesAndPopulations / GWPopulation Pipe
Colm Talbot's avatar
  • 830008e2 · BUG: make jit wrapper less ubiquitous
Colm Talbot's avatar
opened merge request !102 "Draft: ENH: improve jitting of key functions" at RatesAndPopulations / GWPopulation Pipe
Colm Talbot's avatar
  • 177be644 · ENH: improve jitting of key functions
Colm Talbot's avatar
Colm Talbot's avatar
commented on issue #32 "Post-processing stages are very slow" at RatesAndPopulations / GWPopulation Pipe

A potential solution...