Skip to content

Use O3 cache files for O3 unit tests

Patrick Clearwater requested to merge pwc_reg_fixes into master

This fixes the regression with the trigger comparison tests. The main issue was that we were using O2, rather than O3, frame cache files for the O3 tests. But see important caveats below!

I still haven’t identified why the tests ever worked, so I think the conclusion is they never did. Fair enough. :)

The 's190728q' test still doesn’t run because the XML file is borked. I have separately asked Alex to fix this but it depends on a file only he has write permissions to

The tests themselves all say 'Trigger comparison... : False'. I’m unclear if this is a problem caused by what I’ve done, or is a more general problem.

Things not addressed in this MR but worth it for the future:

  • reduce the duplication between all the different run_...._offline.sh variants (maybe following the scheme for the skymap tests)
  • figure out how to get the big files, particularly the XML files, into git-lfs

Merge request reports