Move bilby priors into config file
What?
This MR removes the ability for asimov to generate independent prior files, and instead always writes the prior to the config file to improve reproducability of runs and make review simpler.
Unfortunately the prior dictionary format does not conform to standard TOML format, and this breaks the method used by asimov to open bilby config files in the tests. The solution to this will be to replace the parser (#109) in the long-run, but for now I have unfortunately needed to remove bilby from the tests in the generic config tester.
Why?
During the review of GWTC-3 it became clear that having the prior settings written to a separate file for bilby jobs was awkward and introduced both an unecessary failure mode and an additional piece of information which needed to be reviewed.
It is now possible to specify the "prior dictionary" for bilby directly inside its configuration file, alongside the other configuration settings, so that only a single configuration file is passed to bilby_pipe.
Who?
This MR was prepared by @daniel-williams.
Where?
The main changes in this MR are in the pipelines/bilby.py file, where the logic for writing the separate prior file is removed, and the configs/bilby.ini template file, where the prior settings are transfered from the priors template, which has been removed.
When?
This MR implements a change which has been scheduled for the v0.5.0 release of asimov.
Testing & Review
This MR directly affects the ability of asimov to produce bilby analyses, through affecting the functioning of the configuration file and the removal of the prior file from the asimov manage submit process.
A sufficient test of this functionality would be:
- Create a bilby analysis
- Run
asimov manage buildand verify that the prior dictionary is correctly contained within the configuration file. - Run
asimov manage submitand verify that the analysis completes as expected.
Checklist
-
Code development -
Documentation -
Unit tests -
Release scheduled -
Review