Adding the use of the rts-cpu-isolator.h header, and calling the...

Adding the use of the rts-cpu-isolator.h header, and calling the swappable/better named functions rts_isolator_exec()/rts_isolator_cleanup() instead of cpu up/down directly

Closes #337 (closed)

requested review from @erik.vonreis and @jonathan-hanks

removed review request for @jonathan-hanks and @erik.vonreis

marked this merge request as draft

added 1 commit

• 45aba124 - Fixing set_fe_code_idle( func ), func prototype needs to match the expected...

Compare with previous version

requested review from @erik.vonreis and @jonathan-hanks

added 1 commit

• 8dd8ea93 - Fixing the void* (*) (void*) mismatch with the fe_start_controller and Linux play_dead prototypes

Compare with previous version

marked this merge request as ready

I like it and will approve it. A few questions and comments.

• should we replace set_fe_code_idle with set_rt_callback in everything?

  • Note we would probably need to still expose set_fe_code_idle and implement set_rt_callback as a static inline function that calls set_fe_code_idle. At least in the short term.

• It is a lot nicer to see proper includes instead of random inline forward declarations everywhere.

• We can probably pull the comments out of fe_start_controller_kthread and just note at the function level that it is an adapter to all fe_start_controller to be called as a kthread target + a set_rt_callback.

• Do we need to annotate what the rts-cpu-isolator.h file is including.

approved this merge request

added 4 commits

• 8dd8ea93...18ce7b34 - 3 commits from branch cds:master
• e4329266 - Merge branch 'master' of git.ligo.org:cds/advligorts into issue-337-moduleLoad

Compare with previous version

added 1 commit

• 6a30f779 - Fixing typo, makefile paths and missing linux/cpu.h header include

Compare with previous version

added 1 commit

• dd25ab3f - Cleaning up comments a bit, and making the include base start at src/drv/

Compare with previous version

merged

mentioned in commit 4958df6b