Cleaning up findSharedMemory usage, fixing error checks on the returned... (!297) · Merge requests · CDS / software / advLigoRTS · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 1 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk.

Merged Ezekiel Dohmen requested to merge ezekiel.dohmen/advligorts:rfm-global-cleanup into master 3 years ago

Cleaning up findSharedMemory usage, fixing error checks on the returned pointer, consolidating code for findSharedMemory() and findSharedMemorySize() so we don't have duplicate, removing unused sprintf in both functions, removing the use of the global addr variable.

Would like to test this code in a more complete fashion before marking the MR as ready.

Edited 3 years ago by Ezekiel Dohmen

Activity

Ezekiel Dohmen assigned to @jonathan-hanks and @erik.vonreis 3 years ago

assigned to @jonathan-hanks and @erik.vonreis
Ezekiel Dohmen changed the description 3 years ago

changed the description
Ezekiel Dohmen marked this merge request as ready 3 years ago

marked this merge request as ready
Erik von Reis merged 3 years ago

merged
Erik von Reis mentioned in commit 4405f1e3 3 years ago

mentioned in commit 4405f1e3

Please register or sign in to reply