Skip to content

fix: 18-bit DACs wouldn't set DAC error bit when in HIQTR

Erik von Reis requested to merge erik.vonreis/advligorts:18bit-fix-5.1 into branch-5.1

An IOP will set the DAC error bit if FIFO HIQTR is set for six consecutive cycles, but an off-by-two error prevented the IOP from ever counting that high for 18 bit DACs. 20 Bit DACs and 16 bit DACs were not affected.

I was eventually able to re-create the 18 bit DAC issue on the large test stand and demonstrate that this MR fixes it.

Merge request reports