Option to only have one cursor (rather than 2 t cursors, or 2 y cursors)

It would be nice to have the option for only one t cursor sometimes, rather than both. When, for example, I'm looking at a lockloss, I like to put the t cursor at the actual lockloss time, and then the second one and the text that goes with it is just in the way. Similar for the y cursor sometimes.

added UI label

changed milestone to %ndscope 0.16

When we fix this I would also like to remove the center line between the two cursors in dual cursor mode.

I would like to get the plot menu cursor interface to look like this:

@patrick.thomas Do you think that's something you can figure out? I have some code for actually setting the single/dual cursor mode once we figure the interface out.

I'll take a look.

An example: plot_menu.py

@patrick.thomas Thanks for working on this. Can you just make an MR or a branch with the changes made to the existing plot menu? I can then base the main MR on that.

There appears to be an issue in the current master branch when adding a plot to the layout. If there is a channel name that is not valid in the add channel line edit box in the plot context menu, then the added plot does not have t cursors put on it, even if the already existing plots do.

It appears to have been broken by this commit:

321eba47f445d6fc7d469f021bcf9f5c492ff1af is the first bad commit
commit 321eba47f445d6fc7d469f021bcf9f5c492ff1af
Author: Jameson Graef Rollins <jameson.rollins@ligo.org>
Date:   Fri Jun 10 11:16:23 2022 -0700

    better channel validation before add
    
    This adds better channel name checking during channel add, by adding a
    find_channels call on the channel name if the channel list is not yet
    available.
    
    data.add_channel will throw an UnknownChannelError if the channel is not
    found, and will cause an error, with appropriate error message, if
    channels specified on the command line could not be found.

 ndscope/__main__.py   |  7 ++++++-
 ndscope/data.py       | 16 +++++++++-------
 ndscope/exceptions.py |  2 ++
 ndscope/plot.py       |  5 +----
 4 files changed, 18 insertions(+), 12 deletions(-)
 create mode 100644 ndscope/exceptions.py

Please open a separate issue for that.

!73 (closed)

What do you think about doing it like this? I think the selection is easier, because putting the widget at the same level in the menu as the actions seems to make it harder to select.

plot_menu.py

@patrick.thomas yeah, I think that probably looks better. It looks like you made improvements to the "Y axis scale" menu as well, which is nice. Would you mind updating !71 (merged) with these changes?

What do you think about moving the T cursor settings from the context menu to one of the tabs at the bottom of the scope, since the T cursor settings apply all plots? I think this would make the signaling simpler and it would be consistent with how we put the other things that apply to all plots there.

What do you think about something like this?

plot_menu.py plot_menu.py

Can you just post a screen cap instead of a script? would be easier to review. Thanks.

I purposely put the T cursor in the menu because I think it makes more sense to have the T and Y cursor interfaces be adjacent to each other.

If I go to select a screenshot the menu loses mouse context and disappears.

With the Y and T cursors together: plot_menu.py

That looks pretty nice, but let's just tweak the cursor interface for now, and maybe you can sumit a subsequent MR for other context menu changes for us to evaluate.

Ok. I think that is already done in the current MR?

Do you still want me to update that MR to add the Y scale changes, or make that separate?

Oh, I guess I need to move the cursors into a submenu in that MR.

Ok, I updated the MR to move the cursors into a submenu.

mentioned in merge request !74 (closed)

This feature has now been added to master, and will be in the next 0.16 release.

closed