Previous changes to channel validation breaks enabling of time cursors in new plots
There appears to be an issue in the current master branch when adding a plot to the layout. If there is a channel name that is not valid in the add channel line edit box in the plot context menu, then the added plot does not have t cursors put on it, even if the already existing plots do.
It appears to have been broken by this commit:
321eba47f445d6fc7d469f021bcf9f5c492ff1af is the first bad commit
commit 321eba47f445d6fc7d469f021bcf9f5c492ff1af
Author: Jameson Graef Rollins <jameson.rollins@ligo.org>
Date: Fri Jun 10 11:16:23 2022 -0700
better channel validation before add
This adds better channel name checking during channel add, by adding a
find_channels call on the channel name if the channel list is not yet
available.
data.add_channel will throw an UnknownChannelError if the channel is not
found, and will cause an error, with appropriate error message, if
channels specified on the command line could not be found.
ndscope/__main__.py | 7 ++++++-
ndscope/data.py | 16 +++++++++-------
ndscope/exceptions.py | 2 ++
ndscope/plot.py | 5 +----
4 files changed, 18 insertions(+), 12 deletions(-)
create mode 100644 ndscope/exceptions.py
Edited by Patrick Thomas