Skip to content
Snippets Groups Projects

Refactor and update metric calc

Merged Refactor and update metric calc
feature-test-cbc-m1-m2 into main
Merged James Kennington requested to merge feature-test-cbc-m1-m2 into main

Changes:

  • using numdifftools package as primary metric calculator (Hessian)

  • reimplemented numerical derivatives, though not currently used (will reexamine in future)

  • tested three coordinate systems for local metric accuracy against fft metric:

    • \{m_1, m_2\}
    • \{\log_{10} m_1, \log_{10} m_2\}
    • \{\log_{10} m_1, \log_{10} m_2, \chi \}

  • Added test coverage for utilities

Edited by James Kennington

Merge request reports

Pipeline #274215 passed

Stage: pytest

Pipeline passed for 57244993 on feature-test-cbc-m1-m2

Approval is optional

Merged by James KenningtonJames Kennington 3 years ago (Aug 18, 2021 5:43pm UTC)

Merge details

  • Changes merged into main with e6f4eded (commits were squashed).
  • Deleted the source branch.

Pipeline #274219 passed

Stage: pytest

Pipeline passed for e6f4eded on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply