Replace complicated quality checks with flake8

This MR effectively reverts !63 (merged) in favour of something more like !59 (closed), which is much simpler, using flake8 for the entire analysis.

This also expands the analysis to include docstrings and security issues.

.gitlab/ci/analysis.yml

@@ -8,8 +8,6 @@ include:
     file:
       # https://computing.docs.ligo.org/gitlab-ci-templates/python/
       - python.yml
-      # https://computing.docs.ligo.org/gitlab-ci-templates/codequality/
-      - codequality.yml
 
 # -- code quality -----------
 #
@@ -23,25 +21,15 @@ flake8:
     # https://computing.docs.ligo.org/gitlab-ci-templates/python/#.python:flake8
     - .python:flake8
   needs: []
-  artifacts:
-    paths:
-      - flake8.json
-
-radon:
-  stage: Code quality
-  extends:
-    # https://computing.docs.ligo.org/gitlab-ci-templates/python/#.python:radon
-    - .python:radon
-  needs: []
-  artifacts:
-    paths:
-      - radon.json
-
-codequality:
-  stage: .post
-  extends:
-    # https://computing.docs.ligo.org/gitlab-ci-templates/codequality/#.codequality:combine
-    - .codequality:combine
-  needs:
-    - flake8
-    - radon
+  before_script:
+    # pick requirements out of the setup.cfg
+    - |
+      REQUIREMENTS=$(python -c "
+      from configparser import ConfigParser;
+      cp = ConfigParser();
+      cp.read('setup.cfg');
+      print(cp['options.extras_require']['lint'].strip())")
+    # install things
+    - !reference [".python:flake8", before_script]
+  # code quality issues should present a global 'warning'
+  allow_failure: true