Skip to content
Snippets Groups Projects

Improvements to validating incoming scitokens

This MR improves the validation of incoming auth scitokens, after some real-world testing.

The main functional changes are as follows

  • don't use any custom validators, just set up scitokens.Encforcer and use it's default test() method.
  • explicitly deserialize() tokens with aud:ANY, the enforcer will restrict the audience later

Merge request reports

Pipeline #376213 passed

Pipeline passed for 86d3bddb on duncanmmacleod:scitokens-improvements

Test coverage 85.00% (0.00%) from 7 jobs
Approved by

Merged by Duncan MacleodDuncan Macleod 2 years ago (Mar 29, 2022 2:56pm UTC)

Merge details

  • Changes merged into master with 65338aed.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #376225 passed

Pipeline passed for 65338aed on master

Test coverage 85.00% (0.00%) from 7 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading