Debian packaging: Address #10 #11 #12 and #13

• Add Debian-specific version of service unit file
• Add main package to debian/control
• Provide *.install, *.docs for both packages
• Let dh_systemd (and "dh --with systemd") handle pre/post scripts

Relates #10 (closed), relates #11 (closed), closes #12 (closed), closes #13 (closed)

changed title from Address !10 !11 !12 and !13 to Address #10 #11 #12 and #13

@steffen.grunewald, the fundamental problem in #11 (closed) is that the gunicorn.conf.py file isn't in the tarball, can you add this patch:

diff --git a/MANIFEST.in b/MANIFEST.in
index c1bc5c1..cddfe52 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1,5 +1,5 @@
 include LICENSE
-recursive-include config *.conf *.ini *.service
+recursive-include config *.conf *.conf.py *.ini *.service
 recursive-include debian *
 recursive-include tests *
 include python-gwdatafind-server.spec

added packaging label

assigned to @duncanmmacleod

changed milestone to %GWDataFind Server 1.2.0

@steffen.grunewald, thank you for this! I had put very little effort into Debian packaging (basically just enough to get binaries that pass lintian).

added 1 commit

• 9eb9b0df - add gunicorn.conf.py to tarball

Compare with previous version

marked this merge request as draft

lintian complains about the conffile. Since it has to be copied from its original location into /etc/, rules have to be modified. Also it has to be removed from the install file.

systemd stuff should go into /lib not /etc.

tests fail since scitokens aren't present at runtime

added 5 commits

• bc00bb88 - add python3-scitokens to install deps
• cfaabf57 - remove conffile from install
• 19e20ba9 - there seems to be no other way to copy a conffile
• 29a653e8 - revert 19e20ba9
• 653324cd - another attempt to fix install and conffiles

Compare with previous version

marked this merge request as ready

marked this merge request as draft

added 1 commit

• 7e33c885 - no need to declare files in /etc/ as conffiles

Compare with previous version

marked this merge request as ready

marked this merge request as draft

added 1 commit

• c4533287 - rebase .gitlab-ci.yml

Compare with previous version

added 1 commit

• 2f9befa9 - bump build number to rank above Hypatia packages

Compare with previous version

added 2 commits

• a11a7c70 - quiesce lintian complaint about systemctl
• 825f9af4 - use "--with systemd" to handle service pre/post scripts the Debian way

Compare with previous version

After a lot of experiments, mainly caused by my inability to find proper documentation on *.debian.org, I'm on short final now.

Of all possible ways to get this done, using dh_systemd (nowadays included with debhelper) and the "--with systemd" option is the best: it gets us rid of all pre/post script magic and lintian excuses.

Lintian now only complains about the ancient policy version. I'm not sure what would happen if the compat level was bumped to 10 though.

With all CI stages having succeeded, it's time to remove the Draft status now!

Feel free to remove the *.OFF files (and the *.lintian-overrides one), they are no longer needed (except for documentation purposes). I have learned a lot today.

marked this merge request as ready