Skip to content

Resolve "FrameCPP 2.9.1 is signifigantly slower at writing frames than 2.8.1"

Ed Maros requested to merge ed-maros/LDAS_Tools:164-framecpp-2.9-crc into master

Description

This closes #164 (closed)

The boost general algorithm for CRC calculations introduced a large overhead making it unusable by the LIGO frame builder. The previous LDAS CRC algorithm was restored.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

The code has been validated using extensive unit tests. An additional unit test was created which verifies that the calculated CRC value happens within a timely manner.

Merge request reports