Defer authentication until actually required
This PR moves the call to HTTPECPAuth._init_auth
to the point where it is actually required, rather than forcing users to authenticate when they might not need to.
Merge request reports
Activity
added enhancement label
assigned to @duncanmmacleod
By Duncan Macleod on 2020-03-23T08:32:15 (imported from GitLab)
Created by: codecov[bot]
Codecov Report
Merging #5 into master will increase coverage by
1.83%
. The diff coverage is66.66%
.@@ Coverage Diff @@ ## master #5 +/- ## ========================================== + Coverage 53.21% 55.04% +1.83% ========================================== Files 1 1 Lines 109 109 ========================================== + Hits 58 60 +2 + Misses 51 49 -2
Flag Coverage Δ #8 (closed) ?
#Darwin 55.04% <66.66%> (+1.83%)
#Linux 55.04% <66.66%> (+1.83%)
#Windows 55.04% <66.66%> (+1.83%)
#bullseye 100.00% <ø> (ø)
#buster 100.00% <ø> (ø)
#conda 55.04% <66.66%> (+1.83%)
#python35 54.62% <66.66%> (+1.85%)
#python36 54.62% <66.66%> (+1.85%)
#python37 54.62% <66.66%> (+1.85%)
#python38 55.04% <66.66%> (+1.83%)
#stretch 100.00% <ø> (ø)
Impacted Files Coverage Δ requests_ecp.py 55.04% <66.66%> (+1.83%)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5128b8e...fcc3382. Read the comment docs.By Duncan Macleod on 2020-03-23T08:38:36 (imported from GitLab)
Edited by Ghost UserMerged by: duncanmmacleod at 2020-03-23 08:56:02 UTC
By Duncan Macleod on 2024-06-12T16:01:51 (imported from GitLab)
Edited by Ghost User