Installation and example issues
Hi @matthew-pitkin I'm going to list issues I had following the documentation/examples as part of the review for JOSS
pip install .[test]
Issues with -
pip install htcondor
does not work on Mac OS. A note that this will need to be installed withconda
or from source prior to installingcwinpy
(as is currently done for Tempo). -
pip install .[test]
does not properly link the compiledCython
code. This means thatpytest
fails before starting any tests. A solution is to dopip install -e .[test]
.
To be clear, the full actions that I ran on my MacBook to get the unit tests to run were
$ conda install -c conda-forge libstempo
$ conda install -c conda-forge htcondor
$ pip install -e .[test]
$ pytest
knope
pipeline on the LDG
Running The argument --accounting-group-tag
is listed as accounting-group
in the documentation here.
Examples
example_targeted_pulsar.py
has a broken import, after changing so that the imports are as below, it ran quickly.
from cwinpy import HeterodynedData
from cwinpy.pe.likelihood import TargetedPulsarLikelihood