Skip to content
Snippets Groups Projects
Commit c84a92a1 authored by Patrick Godwin's avatar Patrick Godwin
Browse files

remove dynamic_memory option in Layer

this option has many implicit assumptions that cannot be changed
easily and options that are set are especially brittle regarding
condor versions and/or cluster configurations
parent 643a1359
No related branches found
No related tags found
No related merge requests found
......@@ -35,10 +35,6 @@ class Layer:
transfer_files
Whether to leverage Condor file transfer for moving around
files. On by default.
dynamic_memory
Whether to dynamically increase memory request if jobs are
put on hold due to going over memory requested.
Off by default.
submit_description
The submit descriptors representing this set of jobs.
requirements
......@@ -59,7 +55,6 @@ class Layer:
log_dir: str = "logs"
retries: int = 3
transfer_files: bool = True
dynamic_memory: bool = False
requirements: dict = field(default_factory=dict)
submit_description: Union[dict, htcondor.Submit] = field(default_factory=dict)
nodes: list = field(default_factory=list)
......@@ -267,22 +262,6 @@ class Layer:
# extra boilerplate submit opts
submit["notification"] = "never"
# set dynamic memory opts if requested
if self.dynamic_memory:
base_memory = submit["request_memory"]
submit["+MemoryUsage"] = f"( {base_memory} )"
submit["request_memory"] = "( MemoryUsage ) * 3 / 2"
hold_condition = (
"((CurrentTime - EnteredCurrentStatus > 180)"
" && (HoldReasonCode != 34))"
)
submit["periodic_release"] = " || ".join(
[
submit["periodic_release"],
hold_condition,
]
)
return htcondor.Submit(submit)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment