Include parsing of spin_1z and spin_2z from posterior samples files
Currently the source_classification_pe
function only allows for reading total spin and tilt. We need to make sure that if the samples provide spin_1z
and spin_1z
instead then the code is able to use those too instead of defaulting the spins to zero.
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Shaon Ghosh changed title from Include parsing of {-
-}spin_1z{-
-} and {--}spin_2z{-
-} to Include parsing of spin_1z and spin_2zchanged title from Include parsing of {-
-}spin_1z{-
-} and {--}spin_2z{-
-} to Include parsing of spin_1z and spin_2z - Shaon Ghosh changed title from Include parsing of spin_1z and spin_2z to Include parsing of spin_1z and spin_2z from posterior samples files
changed title from Include parsing of spin_1z and spin_2z to Include parsing of spin_1z and spin_2z from posterior samples files
- Owner
Here is the link to an example posterior sample file: https://gracedb-playground.ligo.org/api/superevents/S230524cd/files/Bilby.posterior_samples.hdf5
- Owner
I thought we had agreed on a naming convention several months back. I recall this patch from @andrew.toivonen to fix the keys: !38 (merged)
Collapse replies - Owner
I think we had confusion between low-latency and bilby developers at the F2F, as we chose to use
spin_{1,2}z
at that time: lscsoft/bilby_pipe@859ac6d3.
- Deep Chatterjee marked this issue as related to #20 (closed)
marked this issue as related to #20 (closed)
- Owner
OK. Any takers for a MR and updating the unittest? @andrew.toivonen you did the original one. But if you are busy with the paper, do you want to give it a shot @yu-kuang.chu?
Collapse replies - Developer
I can try to work on this if people are okay with that.
- Developer
So, basically, it's updating the function and adding the corresponding unit test. Then, submit the MR for review. It is that correct?
- Owner
thank you.
- Yu-Kuang Chu created branch
34-include-parsing-of-spin_1z-and-spin_2z-from-posterior-samples-files
to address this issuecreated branch
34-include-parsing-of-spin_1z-and-spin_2z-from-posterior-samples-files
to address this issue - Yu-Kuang Chu mentioned in merge request !55 (closed)
mentioned in merge request !55 (closed)
- Deep Chatterjee mentioned in commit 5cf44efc
mentioned in commit 5cf44efc
- Deep Chatterjee mentioned in merge request !56 (merged)
mentioned in merge request !56 (merged)
- Deep Chatterjee closed with commit 5cf44efc
closed with commit 5cf44efc
- Deep Chatterjee closed with merge request !56 (merged)
closed with merge request !56 (merged)
- Deep Chatterjee mentioned in merge request emfollow/gwcelery!1227 (merged)
mentioned in merge request emfollow/gwcelery!1227 (merged)
- Developer
The code still defaults the spins to zero if they cannot be read, although as far as I can see doing this cannot lead to a correct result.
It seems preferable for the code to throw an error rather than produce an incorrect result.
Collapse replies - Owner
Tom, we have discussed the schema with the online pe team. The absence of the correct string names implies a run with non spinning waveforms. If the schema changes, we will coordinate that with the pe group.
- Developer
OK, if a non-spinning run is still a possibility.