Properties and classification set incorrectly in significant burst alerts

The kafka notices associated with S230808i, the first significant alert of O4 that only had a cWB g-event, were sent out with a bunch of links to non-public files in the superevent. These links were in the event.properties and event.classification sections of the notice, which should be empty for burst events. One example of a messed up notice can be seen here.

Update 1: It appears this only happened in the initial alert, not the preliminary alerts.

Update 2: This alert did not get sent via SCiMMA, because it didn't pass the runtime validation check used in the avro serialized messages. That resulted in this sentry error.

changed milestone to %GWcelery v2.1.6 Release

added Core label

added to epic &11

mentioned in merge request !1292 (merged)

regression due to !1212 (merged), the result of download_andor_expose_group needs to be piped into kafka_alert_canvas somehow in orchestrator.earlywarning_preliminary_initial_update_alert

I'm not entirely clear how that task is supposed to work for Burst events where em_bright and p_astro aren't available

Nevermind, I'm not sure earlywarning_preliminary_initial_update_alert gets called in a way that would cause this. That might still be a bug though.

changed the description

changed the description

I think I understand the problem. For burst events, p_astro_filename and em_bright_filename will be None here. I just checked, and the gracedb_sdk library will just return the names of all of the files of a superevent if you give it None as a filename. This then gets passed as the p_astro and em_bright filecontents to the downstream task that constructs the notice.

In [3]: client = gracedb_sdk.Client('https://gracedb-playground.ligo.org/api/')

In [5]: test = client.events['S230808eo'].files[None].get()

In [6]: test
Out[6]: <urllib3.response.HTTPResponse at 0x7f7f729ab820>

In [7]: test.read()
Out[7]: b'{"H1_omegascan.png":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/H1_omegascan.png","H1_omegascan.png,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/H1_omegascan.png,0","L1_omegascan.png":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/L1_omegascan.png","L1_omegascan.png,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/L1_omegascan.png,0","S230808eo-1-EarlyWarning.xml":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-1-EarlyWarning.xml","S230808eo-1-EarlyWarning.xml,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-1-EarlyWarning.xml,0","S230808eo-2-Preliminary.xml":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-2-Preliminary.xml","S230808eo-2-Preliminary.xml,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-2-Preliminary.xml,0","S230808eo-3-Preliminary.xml":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-3-Preliminary.xml","S230808eo-3-Preliminary.xml,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-3-Preliminary.xml,0","S230808eo-earlywarning.avro":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-earlywarning.avro","S230808eo-earlywarning.avro,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-earlywarning.avro,0","S230808eo-earlywarning.json":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-earlywarning.json","S230808eo-earlywarning.json,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-earlywarning.json,0","S230808eo-preliminary.avro":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-preliminary.avro","S230808eo-preliminary.avro,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-preliminary.avro,0","S230808eo-preliminary.avro,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-preliminary.avro,1","S230808eo-preliminary.json":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-preliminary.json","S230808eo-preliminary.json,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-preliminary.json,0","S230808eo-preliminary.json,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/S230808eo-preliminary.json,1","V1_omegascan.png":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/V1_omegascan.png","V1_omegascan.png,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/V1_omegascan.png,0","bayestar.fits.gz":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.fits.gz","bayestar.fits.gz,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.fits.gz,0","bayestar.fits.gz,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.fits.gz,1","bayestar.fits.gz,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.fits.gz,2","bayestar.html":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.html","bayestar.html,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.html,0","bayestar.html,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.html,1","bayestar.html,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.html,2","bayestar.multiorder.coherence.png":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.multiorder.coherence.png","bayestar.multiorder.coherence.png,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.multiorder.coherence.png,0","bayestar.multiorder.coherence.png,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.multiorder.coherence.png,1","bayestar.multiorder.coherence.png,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.multiorder.coherence.png,2","bayestar.multiorder.fits":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.multiorder.fits","bayestar.multiorder.fits,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.multiorder.fits,0","bayestar.multiorder.fits,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.multiorder.fits,1","bayestar.multiorder.fits,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.multiorder.fits,2","bayestar.png":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.png","bayestar.png,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.png,0","bayestar.png,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.png,1","bayestar.png,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.png,2","bayestar.volume.png":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.volume.png","bayestar.volume.png,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.volume.png,0","bayestar.volume.png,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.volume.png,1","bayestar.volume.png,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/bayestar.volume.png,2","earlywarning-circular.txt":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/earlywarning-circular.txt","earlywarning-circular.txt,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/earlywarning-circular.txt,0","em_bright.json":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/em_bright.json","em_bright.json,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/em_bright.json,0","em_bright.json,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/em_bright.json,1","em_bright.json,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/em_bright.json,2","em_bright.png":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/em_bright.png","em_bright.png,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/em_bright.png,0","em_bright.png,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/em_bright.png,1","em_bright.png,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/em_bright.png,2","gwcelerydetcharcheckvectors-S230808eo.json":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/gwcelerydetcharcheckvectors-S230808eo.json","gwcelerydetcharcheckvectors-S230808eo.json,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/gwcelerydetcharcheckvectors-S230808eo.json,0","gwskynet.json":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/gwskynet.json","gwskynet.json,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/gwskynet.json,0","preliminary-circular.txt":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/preliminary-circular.txt","preliminary-circular.txt,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/preliminary-circular.txt,0","preliminary-circular.txt,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/preliminary-circular.txt,1","pycbc.p_astro.json":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/pycbc.p_astro.json","pycbc.p_astro.json,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/pycbc.p_astro.json,0","pycbc.p_astro.json,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/pycbc.p_astro.json,1","pycbc.p_astro.json,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/pycbc.p_astro.json,2","pycbc.p_astro.png":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/pycbc.p_astro.png","pycbc.p_astro.png,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/pycbc.p_astro.png,0","pycbc.p_astro.png,1":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/pycbc.p_astro.png,1","pycbc.p_astro.png,2":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/pycbc.p_astro.png,2","rapidpe.ini":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/rapidpe.ini","rapidpe.ini,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/rapidpe.ini,0","rapidpe_dag.log":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/rapidpe_dag.log","rapidpe_dag.log,0":"https://gracedb-playground.ligo.org/api/superevents/S230808eo/files/rapidpe_dag.log,0"}'

mentioned in merge request !1293 (merged)

closed with commit 8387a4e8

closed with merge request !1293 (merged)