clean up superevent on SIGNIFICANT_LABEL
Port over part of !1051 (merged) to fix #537 (closed)
The reason for #537 (closed) is as follows:
- EM_Selected freezes superevent. But it does not launch less-significant alerts yet. That will be done in !1051 (merged).
- In this patch, we port over the part of !1051 (merged) which cleans up the superevent on EM_SelectedConfident before sending the significant alert.
- Without this change, superevents that start out with a less significant G-event will have the alert not be sent due to failure to satisfy publishability condition: https://git.ligo.org/emfollow/gwcelery/-/blob/main/gwcelery/tasks/orchestrator.py#L700-707
- Another subtle but important change is needed in !1051 (merged) but refactored here: the
superevents.keyfunc
should explicitly order significant events higher than less-significant events i.e. a FAR=1e-5, SNR=12 is lower ranked than FAR=1e-10, SNR=11.
Edited by Deep Chatterjee