Draft: zero pad discontiguous segments for omega scans
partly resolves #183 (closed)
(This will likely taking care of by a new version of gwpy)
Merge request reports
Activity
requested review from @geoffrey.mo
Do we have any way to confirm that there isn't some different underlying issues causing #183 (closed) that this will just sweep under the rug?
Based on the docs. the
.readwill give a ValueError for discontiguous caches passed.Based on however many instance of this error I eyeballed, all of them came from the O3 Replay channel e.g.
and almost all of then had "several nines" after the decimal.
-
I managed to snag some frames near the time of one of these errors and confirmed I can reproduce the error. I'm going to respond to Duncan's comment (#183 (comment 102673)) to see if we can figure out what's going on.
I'm fine with your proposal, but can you leave #183 (closed) open and include a link to it with a
FIXMEand a comment that explains that the workaround can be removed if we fix the underlying issue? -
done. I also removed the "fix #183 (closed)" phrase from the commit message so it does not close the issue.
-
I just found something concerning that I'd like to try to understand before we merge.
I can reproduce this problem with our deployments, but I am unable to reproduce it elsewhere even when using the same versions of glue and gwpy. I'm worried that means there's a problem somewhere in one of our dependencies.
138 ts = TimeSeries.read(cache, strain_name, 139 start=long_start, end=long_end).astype('float64') 139 try: 140 ts = TimeSeries.read( 141 cache, strain_name, start=long_start, 142 end=long_end 143 ).astype('float64') 144 except ValueError as e: 145 # retry with zero padding in case of minor discontiguous segments 146 # Typical example involves number of nines at the end for first 147 # timeseries. E.g. 148 # Cannot append discontiguous TimeSeries 149 # TimeSeries 1 span: [1388412795.5441284 ... 1388412795.999939) 150 # TimeSeries 2 span: [1388412796.0 ... 1388412797.0) 151 pattern = ( 152 r'.*\[([0-9]+\.[0-9]+) ... ([0-9]+\.9{2,}).*\n' added 1 commit
- c752f935 - zero pad slightly discontiguous segments when creating omega scans
added 1 commit
- 60e7e563 - zero pad slightly discontiguous segments when creating omega scans
-
CLosing in favor of !1366 (merged)