Create combined sky map and spacetime coincidence FAR automatically

Similar to waiting for g-events to be complete, we will wait to compare or combine sky maps until the external event is complete:

• comparing: when there is a coincidence (EM_COINC), and both sky maps are available (se: SKYMAP_READY, ext: LUMIN_GO)
• combine: when there is a raven alert (RAVEN_ALERT), and both sky maps are available (se: SKYMAP_READY, ext: LUMIN_GO)

If the external event is not complete we will look whether a superevent sky map is available and apply SKYMAP_READY if it is. Note we also apply SKYMAP_READY to all related external events when the superevent sky map is first available. The first case catches times where the superevent sky map comes in after the coincidence is found (EM_COINC applied) and the latter case catches time where the superevent sky map comes in before the coincidence is found.

gwcelery/tasks/external_skymaps.py

@@ -3,7 +3,6 @@ from astropy import units as u
 from astropy.coordinates import ICRS, SkyCoord
 from astropy_healpix import HEALPix, pixel_resolution_to_nside
 #  import astropy.utils.data
-from celery import group
 import numpy as np
 from ligo.skymap.io import fits
 from ligo.skymap.tool import ligo_skymap_combine
@@ -20,29 +19,28 @@ from ..util.tempfile import NamedTemporaryFile
 from ..import _version
 
 
-def create_combined_skymap(graceid):
+def create_combined_skymap(se_id, ext_id):
     """Creates and uploads the combined LVC-Fermi skymap.
 
     This also uploads the external trigger skymap to the external trigger
     GraceDB page.
     """
-    preferred_skymap = get_preferred_skymap(graceid)
-    message = 'Combined LVC-Fermi sky map using {0}.'.format(preferred_skymap)
-    new_skymap = re.findall(r'(.*).fits', preferred_skymap)[0] + '-gbm.fits.gz'
-    external_trigger_id = external_trigger(graceid)
-    return (external_trigger_heasarc.s(external_trigger_id) |
-            get_external_skymap.s() |
-            group(
-                combine_skymaps.s(gracedb.download(preferred_skymap,
-                                                   graceid)) |
-                gracedb.upload.s(
-                    new_skymap, graceid, message, ['sky_loc', 'public']),
-
-                gracedb.upload.s('glg_healpix_all_bn_v00.fit',
-                                 external_trigger_id,
-                                 'Sky map from HEASARC.',
-                                 ['sky_loc', 'public']))
-            )
+    se_skymap_filename = get_preferred_skymap(se_id)
+    ext_skymap_filename = get_external_skymap_filename(ext_id)
+    new_skymap_filename = (re.findall(r'(.*).fits', se_skymap_filename)[0] +
+                           '-ext.fits.gz')
+
+    se_skymap = gracedb.download(se_skymap_filename, se_id)
+    ext_skymap = gracedb.download(ext_skymap_filename, ext_id)
+    message = 'Combined LVC-external sky map using {0}.'.format(
+        se_skymap_filename)
+
+    (
+        combine_skymaps.si(se_skymap, ext_skymap)
+        |
+        gracedb.upload.s(new_skymap_filename, se_id,
+                         message, ['sky_loc', 'public'])
+    ).delay()
 
 
 @app.task(autoretry_for=(ValueError,), retry_backoff=10,
@@ -172,6 +170,8 @@ def get_upload_external_skymap(graceid):
                 graceid,
                 'Sky map from HEASARC.',
                 ['sky_loc'])
+            |
+            gracedb.create_label.si('LUMIN_GO', graceid)
         ).delay()
 
     except ValueError:
@@ -300,4 +300,6 @@ def create_upload_external_skymap(event):
                          graceid,
                          message,
                          ['sky_loc'])
+        |
+        gracedb.create_label.si('LUMIN_GO', graceid)
     ).delay()