Shutdown igwn-alert listener properly

requested review from @leo-singer

assigned to @deep.chatterjee

resolved all threads

added 1 commit

0962bca8 - until_eos is True

Compare with previous version

Looks like this is adapting some code from inside igwn-alert? This should probably go upstream.

So here are the two approaches I tried.

first was to try sending a SIGINT, or SIGTERM signal to the thread in the bootstep stop. My hope was that it will trigger the exceptions here: https://git.ligo.org/computing/igwn-alert/client/-/blob/main/igwn_alert/client.py#L245 and stop the listener. Sadly, it does not work.
My next idea was to use some attribute like a shutdown that will be set in the bootstep stop, and would signal the runloop to terminate. But that would mean overriding the main runloop since such an attribute is not there in the igwn alert client, which is why you see code being adapted from the igwn alert client.

Sadly the changes so far have also not yet fixed the issue of the thread terminating after closing the connection. I'll probably have to talk with Alex about this.

added 1 commit

1f3a5c2b - fix [ci-skip]

Compare with previous version

added 1 commit

9d523648 - testing with dev branches of adc and hop

Compare with previous version

This works using my own branch of adc-streaming and hop-client. This will probably need small changes in both adc-streaming and hop-client. I will open merge requests there, but that will probably take longer to resolve and merge. I suggest moving #424 (closed) to a later milestone.