Use adc Consumer stop functionality to terminate IGWNReceiverThread properly

Fixes #424 (closed)

requested review from @cody.messick

assigned to @deep.chatterjee

added 1 commit

• 06dd2992 - minor fix

Compare with previous version

added 1 commit

• 205630e4 - remove unnecessary try except [ci-skip]

Compare with previous version

added 1 commit

• f99c3933 - cosmetics [ci-skip]

Compare with previous version

I'll keep this marked as draft, but just wanted to add that over the last 20 hours, I have under different occasions (a total of 8 times), tried removing the jobs using gwcelery condor rm and every single time it has closed the connection to the broker and the IGWNReceiverThread has terminated successfully. I will attach the logs here for record. Also, will send a pointer about this on the PR on the adc-streaming project

gwcelery-worker.log.aug_30.gz

gwcelery-worker.log.aug_31.gz

Is this in a PR for adc-streaming?

Yep. It's merged now https://github.com/astronomy-commons/adc-streaming/pull/58

OK, great. Would you please update pyproject.toml to point to the commit on the main repo? Other than that I am happy with this.

Will update and rebase

added 10 commits

• f99c3933...3e7f2741 - 4 commits from branch emfollow:main
• 197f010c - attach adc Consumer with running attribute [skip-ci]
• 01be509a - minor fix
• ee76831c - remove unnecessary try except [ci-skip]
• d8b979ac - cosmetics [ci-skip]
• 358426af - install bleeding-edge adc-streaming
• 78323b29 - fix [skip-ci]

Compare with previous version

added 1 commit

• 4f6f5270 - update lock file

Compare with previous version

Is this still a draft because the changes are not yet in an upstream release?

marked this merge request as ready

changed title from Draft: attach adc Consumer with running attribute [skip-ci] to Use adc Consumer stop functionality to terminate IGWNReceiverThread properly

added 1 commit

• c42e6bce - stop listener thread properly using adc-streaming Consumer stop method

Compare with previous version

We can wait for the release to happen, or merge it now. Removed the draft description. I think there should also be a corresponding stop method in the hop-client since right now we access the private consumer.

approved this merge request

added 1 commit

• 18b73f97 - stop listener thread properly using adc-streaming Consumer stop method

Compare with previous version

Just confirming that after the changes to pyproject.toml and installing from the lock file this runs and terminates fine on emfollow-test.

This MR is approved. Are you planning to merge it?

merged

mentioned in merge request !1280 (closed)