Skip to content
Snippets Groups Projects

Upload kafka alert notice after sending

Merged Cody Messick requested to merge cody.messick/gwcelery:upload_alert_dict into main

This MR will upload the alert dictionary as a json file to the superevent after kafka alerts have been sent. It's uploaded after because the kafka alert worker currently uses a solo pool, so adding this upload task to the kafka alert send group before the send tasks would delay the alerts (see #450).

Oct 6 edit: The task that uploads the notice json to gracedb now is next in the chain after the tasks that send the kafka notices, instead of being in the same group.

Oct 11 edit: The task now adds an upload task to the queue instead of performing the upload itself, and uploads the serialized messages (i.e. a .avro file for the scimma notice and a .json file for the gcn notice).

This MR depends on !944 (merged) because the unit tests fail due to the skymap being included in the alert dictionary when uploading after sending the alerts. !944 (merged) makes it so the skymap is never added to the alert_dict variable that is shared between tasks.

Edited by Cody Messick

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Leo Pound Singer
  • mentioned in issue #457 (closed)

  • Cody Messick added 8 commits

    added 8 commits

    • 67d7e41c...732772c1 - 7 commits from branch emfollow:main
    • ab2186bf - Upload alert dictionary used to generate Kafka alert notices to gracedb

    Compare with previous version

  • Cody Messick added 1 commit

    added 1 commit

    • a4b21f0e - Upload alert dictionary used to generate Kafka alert notices to gracedb

    Compare with previous version

  • Cody Messick added 1 commit

    added 1 commit

    • 0fa0b901 - Upload alert dictionary used to generate Kafka alert notices to gracedb

    Compare with previous version

  • Cody Messick changed the description

    changed the description

  • Cody Messick marked this merge request as draft

    marked this merge request as draft

  • Cody Messick added 2 commits

    added 2 commits

    • d9fd9d18 - 1 commit from branch emfollow:main
    • 9fee1cb7 - Upload alert dictionary used to generate Kafka alert notices to gracedb

    Compare with previous version

  • Cody Messick marked this merge request as ready

    marked this merge request as ready

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading