Add HIGH_PROFILE explanation
Description
Fixes #389 (closed).
Added an explanation about HIGH_PROFILE label in vetting.rst as well as glossary. Added a line to change log.
Checklist
Thanks for your contribution! Please complete and check off the following quality control tasks.
Changes:
-
I created this merge request from my own fork and from a branch other than main or master. -
I checked that the CI pipeline completes without errors (except for linkcheck). -
I added a change log entry (or this is a minor change that does not require a change log entry).
Whitespace:
-
No line that I added ends with trailing whitespace. -
Every file that I modified ends with one blank line.
Grammar and spelling:
-
I proofread my contribution and made sure that it is free from spelling and grammatical errors. -
I used American English rather than British English spelling. -
I used the Oxford (serial) comma in lists of three or more items. -
I minimized use of the passive voice.
Figures and code:
-
I contributed plot directive code to generate figures (or I did not contribute any figures). -
I contributed Python code that conforms to the PEP 8 style guide (or I did not contribute Python code).
Merge request reports
Activity
assigned to @keita.kawabe
mentioned in issue #389 (closed)
- I would make
candidate
andpublic alert
singular in the paragraph !292 (diffs). - Line !292 (diffs) has
Superevent
andsuper event
. - The sentence !292 (diffs) doesn't look complete to me.
- In the sentence !292 (diffs), I would remove
for RRT's internal purposes
given that the label is public at the end. -
!292 (diffs): I would write
In rare cases, RRT might apply manually the HIGH_PROFILE label to superevents (...)
. -
!292 (diffs): I would add commas around
with an accompanying GCN Circular
. -
!292 (diffs):
will be
->is
.
- I would make
Thanks for working on this, Keita. Below are my editing suggestions for the file
vetting.rst
. Some of these duplicate what Nicolas wrote above.- "in a Superevent" --> "in a superevent"
- "even whether or not" --> "whether or not"
- "in the super event" --> "in the superevent"
- ":term:
CBC
trigger is preferred" --> "A :term:CBC
trigger is preferred" - "AND is likelier to be of astrophysical origin" --> "AND has less than 0.5 probability of being terrestrial"
- "Probability that the amount of neutron star material remained outside the final remnant compact object is larger than 0.1" --> "Probability that some neutron star material remains outside the final black hole remnant is larger than 0.1"
- "than 100 degrees squared" --> "than 100 square degrees"
- "As soon as one of" --> "If one of"
- "one of these condition" --> "one of these conditions"
- "even when the candidate is retracted" --> "even if the candidate is retracted"
Thanks @nicolas.arnaud and @peter-shawhan. I believe that all of your points were addressed.
marked the checklist item I contributed plot directive code to generate figures (or I did not contribute any figures). as completed
marked the checklist item I contributed Python code that conforms to the PEP 8 style guide (or I did not contribute Python code). as completed
marked the checklist item I used American English rather than British English spelling. as completed
- Resolved by Keita Kawabe
- Resolved by Keita Kawabe
- Resolved by Keita Kawabe
- Resolved by Keita Kawabe
- Resolved by Leo Pound Singer
I am worried that this text may be a bit hard to follow because we have so many similar-sounding concepts: high profile events, significant events, preferred events. Is there anything that you can do to clarify the relationship between these concepts?
- Resolved by Keita Kawabe
- Resolved by Keita Kawabe
- Automatically resolved by Keita Kawabe