fix bug in ASC readouts (!25) · Merge requests · finesse / finesse-ligo · GitLab

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 30 April 2024 starting at approximately 9am PDT. It is expected to take around twenty minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk.

Kevin Kuns requested to merge kevin.kuns/finesse-ligo:ASC-bugfix into ddb Nov 22, 2023

ReadoutRF frequencies were not being set in add_ASC_readouts.
Added factory test for FrequencyResponse; test_make_and_lock did not previously catch the problem with the ReadoutRF frequency not being set.
Slightly refactored the factories for more uniform treatment of LSC and ASC.
Nuked the last vestiges of katscript in the factories. Sayonara.

The factoring of the factories is still a bit strange which is why several methods are added to the base DRFPMIFactory to be overloaded.

Reordering of the test parameterization is more convenient for pytest watching from the command line.