Skip to content

Fix bug in FakeSeriesSource for Sine type timing

James Kenningtonrequested to merge
feature-fake-src-sine-duration into main

This MR fixes a bug due to inconsistent units for the duration argument of a SeriesBuffer (ns) and the duration argument of a TSSource (s). Those conventions are left in place pending a longer discussion, however, the bug is fixed using the SeriesBuffer.tarr property to get an accurate array of times for computing the sine source.

This MR also changes the is_gap attribute of the TSFrame class to be dynamic, instead of static. This is necessary since TSFrame has an iterable of SeriesBuffer objects, each of which is mutable. This is most relevant in FakeSeriesSource when creating new frames. The source creates "empty" buffers, creates the TSFrame object containing them, then fills them with the appropriate data. This leads to an incorrect value of is_gap=True for all frames produced by FakeSeriesSource.

Edited by James Kennington

Merge request reports