Add new mode to FakeSeriesSource
This MR adds two new modes of operation to FakeSeriesSource:
- 'const_int' or 'constant_int': provides a source pad with a constant stream of integers, as specified by the user
- 'const_float or 'constant_float': provides a source pad with a constant stream of floats, as specified by the user
Unit tests for each of these modes have been added as well.
These two modes are useful for testing various calibration-related elements in order to mimic things like front-end oscillator channels or front-end state vector channels.
Merge request reports
Activity
I wonder if we actually need two new parameters, both
const_int
andconst_float
. What if we just had one new parameter,const
, and just used the data type of the provided value as the type of the data from the source. I think we could convince mypy to accept both int and float for the value of theconst
argument.- Resolved by Madeline Wade
- Resolved by Madeline Wade
Thanks @madeline-wade I will let @yun-jing.huang chime in, but I am good with this as long as it maintains test coverage and all checks in "make" pass.
I think @jameson.rollins's suggestion makes sense. The rest looks fine to me.
added 1 commit
- 11c087e4 - Updating unit test to combine const int and float source
mentioned in commit ab8cf38d