Skip to content
Snippets Groups Projects

Add new mode to FakeSeriesSource

Merged Madeline Wade requested to merge madeline-wade/sgn-ts:add-const-to-fakeseries-src into main
All threads resolved!

This MR adds two new modes of operation to FakeSeriesSource:

  • 'const_int' or 'constant_int': provides a source pad with a constant stream of integers, as specified by the user
  • 'const_float or 'constant_float': provides a source pad with a constant stream of floats, as specified by the user

Unit tests for each of these modes have been added as well.

These two modes are useful for testing various calibration-related elements in order to mimic things like front-end oscillator channels or front-end state vector channels.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks @madeline-wade I will let @yun-jing.huang chime in, but I am good with this as long as it maintains test coverage and all checks in "make" pass.

  • I think @jameson.rollins's suggestion makes sense. The rest looks fine to me.

  • Madeline Wade added 1 commit

    added 1 commit

    • 5fd59db1 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Madeline Wade resolved all threads

    resolved all threads

  • Madeline Wade added 1 commit

    added 1 commit

    • e525a65e - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Madeline Wade added 1 commit

    added 1 commit

    • 11c087e4 - Updating unit test to combine const int and float source

    Compare with previous version

  • Madeline Wade added 1 commit

    added 1 commit

    Compare with previous version

  • I incorporated Jamie's suggestion, updated the test and have fixed the formatting issues with mypy. Is there anything else that should be addressed before this is merged?

  • Jameson Rollins approved this merge request

    approved this merge request

  • Jameson Rollins mentioned in commit ab8cf38d

    mentioned in commit ab8cf38d

  • Please register or sign in to reply
    Loading