Skip to content
Snippets Groups Projects

rename TransformElement.transform method to .new

Merged Jameson Rollins requested to merge jameson.rollins/sgn:mr-transform-new into main
All threads resolved!

Keeps it consistent with SourceElement.new

closes #10 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • these changes seem harmless, I assume the motivation is to make TransformElements more consistent with SourceElements?

  • James Kennington approved this merge request

    approved this merge request

  • added 1 commit

    • be653604 - rename TransformElement.transform method to .new

    Compare with previous version

  • Jameson Rollins reset approvals from @james.kennington by pushing to the branch

    reset approvals from @james.kennington by pushing to the branch

  • Jameson Rollins resolved all threads

    resolved all threads

  • James Kennington approved this merge request

    approved this merge request

  • @jameson.rollins this seems fine to me. Thank you for also putting together the sgn-ts merge request. Before we merge someone will need to put in MRs for sgn-ligo and sgnl. I think Yun-Jing and I can do that but probably not till later today.

  • mentioned in commit 5fb3af44

  • Please register or sign in to reply
    Loading