Resolving Issue 85: TypeError in coatingthermal with old version of numpy
Compare changes
+ 5
− 5
@@ -935,8 +935,8 @@ def getCoatReflAndDer(nN, nsub, dOpt):
@@ -955,11 +955,11 @@ def getCoatReflAndDer(nN, nsub, dOpt):
Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.
Resolving the issue mentioned in Issue 85 regarding the behavior of np.flip in numpy versions before 1.15. Modern np.flip has a default axis option while older versions required you to give an axis specifically. We are only flipping 1-dimensional arrays so I have replaced all np.flip with np.flipud which is equivalent to calling np.flip(m, 0). This should solve the issue. However, locally I could not confirm this as I was having segmentation fault error. The local CI test also couldn't pass due to a problem with all package. So hopefully, the reviewers can test this branch in the appropriate place. I don't see a reason for why this would fail with older numpy versions now.