Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • pygwinc pygwinc
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 42
    • Issues 42
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • gwincgwinc
  • pygwincpygwinc
  • Merge requests
  • !137

fix coating parameter misnomer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Kevin Kuns requested to merge kevin.kuns/pygwinc:coating-parameter-misnomer into master Jun 16, 2021
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 7

As is pointed out in #4 the parameters ThermalDiffusivityhighn and ThermalDiffusivitylown are actually the thermal conductivities. Two of the yaml files point this out in the comments but the others didn't. To make matters worse some of the files don't have units.

The comments to that issue suggest just making this change and there were only positive responses. This merge request changes the parameter names to ThermalConductivity{high,low}n and adds units to the yaml file comments

closes #4

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: coating-parameter-misnomer