Skip to content
Snippets Groups Projects

Fix an error in the coating brownian noise calculation

Merged Christopher Wipf requested to merge ctn-fix into master
All threads resolved!

A discrepancy was found by Gabriele Vajente between the gwinc CTN calculation and several other codes, especially in the case of large Poisson ratio in the coating.

See: https://git.ligo.org/gabriele-vajente/thermal-noise-models

This commit resolves the discrepancy by fixing an apparent error in the Yam et al calculation that was implemented in gwinc.

Edited by Jameson Rollins

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christopher Wipf resolved all threads

    resolved all threads

  • added 1 commit

    • c9112f1d - coatingthermal.py: formatting fixes

    Compare with previous version

  • Christopher Wipf resolved all threads

    resolved all threads

  • added 1 commit

    • 84791178 - Fix an error in the coating brownian noise calculation

    Compare with previous version

  • Jameson Rollins approved this merge request

    approved this merge request

  • @christopher.wipf you want to followup with a separate MR to update the test cache?

    I want to figure out a better way to handle MR that change noise curves. We want to generate the report that shows the change, but then not have to go through a separate step to update. Open to suggestions...

    Edited by Jameson Rollins
  • Christopher Wipf mentioned in merge request !78 (merged)

    mentioned in merge request !78 (merged)

  • Jameson Rollins resolved all threads

    resolved all threads

  • Evan Hall approved this merge request

    approved this merge request

  • Jameson Rollins changed the description

    changed the description

  • Jameson Rollins unapproved this merge request

    unapproved this merge request

  • Jameson Rollins added 36 commits

    added 36 commits

    Compare with previous version

  • Evan Hall approved this merge request

    approved this merge request

  • Jameson Rollins added 7 commits

    added 7 commits

    Compare with previous version

  • Jameson Rollins approved this merge request

    approved this merge request

  • Jameson Rollins enabled an automatic merge when the pipeline for a813f541 succeeds

    enabled an automatic merge when the pipeline for a813f541 succeeds

  • Jameson Rollins mentioned in commit fc21470a

    mentioned in commit fc21470a

  • Please register or sign in to reply
    Loading