Skip to content

Simplify dataset handling in get_urls and allow partial matches

Ghost User requested to merge github/fork/duncanmmacleod/get_urls-match-datasets into main

This PR simplifies gwosc.locate.get_urls handling of datasets to enable users to supply a partial match to a dataset in the named argument.

The upshot of this is that the following command that used to fail:

❯ python -c "from gwosc.locate import get_urls; print(get_urls('H1', 1187006834, 1187006835, dataset='O2'))"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\spxdmm\git\gwosc\gwosc\locate.py", line 101, in get_urls
    dstypes = (datasets.dataset_type(dataset),)
  File "C:\Users\spxdmm\git\gwosc\gwosc\datasets.py", line 587, in dataset_type
    raise ValueError(
ValueError: failed to determine type for dataset 'O2'

now matches O2 to the relevant dataset:

❯ python -c "from gwosc.locate import get_urls; print(get_urls('H1', 1187006834, 1187006835, dataset='O2'))"
['https://www.gw-openscience.org/archive/data/O2_4KHZ_R1/1186988032/H-H1_GWOSC_O2_4KHZ_R1-1187004416-4096.hdf5']

cc @camurria

Merge request reports