DEV: neaten calibration marginalization to enable reconstruction
As an alternative to lscsoft/bilby!1234 (diffs) I removed the obstacle to the reconstruction in the way the likelihood is calculated. It turns out this was as simple as changing
return logsumexp(log_l_tc_array, b=time_prior_array)
to
return logsumexp(log_l_tc_array, b=time_prior_array, axis=-1)
The other changes are condensing two methods into one that allowed some of the control flow to be made more consistent.
Merge request reports
Activity
added 12 commits
-
279ddcf2...2061de43 - 11 commits from branch
john-veitch:time-calibration
- ca4b03f1 - Merge branch 'time-calibration' into 'time-calibration-reconstruction'
-
279ddcf2...2061de43 - 11 commits from branch
mentioned in merge request lscsoft/bilby!1234 (merged)
added 1 commit
- 88c52d2a - BUGFIX: add case of just time and calibration marginalzation
Thanks @colm.talbot. This seems to work fine for my test case.
enabled an automatic merge when the pipeline for 88c52d2a succeeds
mentioned in commit ec10acda