API change in ligo.lw.utils.process.register_to_xmldoc, intended?
Running a gstlal job using ligo-lw 1.7.1 is throwing me an error in calling register_to_xmldoc
:
Traceback (most recent call last):
File "/home/patrick.godwin/local/gcc_master_210203/opt/bin/gstlal_inspiral_create_prior_diststats", line 166, in <module>
process = ligolw_process.register_to_xmldoc(xmldoc, u"gstlal_inspiral_create_prior_diststats", paramdict = process_params, ifos = options.instrument)
File "/usr/lib64/python3.6/site-packages/ligo/lw/utils/process.py", line 109, in register_to_xmldoc
process = proctable.RowType.initialized(program = program, process_id = proctable.get_next_id(), **kwargs)
TypeError: initialized() got an unexpected keyword argument 'ifos'
- Before: https://git.ligo.org/kipp.cannon/python-ligo-lw/-/blob/5b8eaa7eaabffbe72fab2c46f696811f473a4a4f/ligo/lw/utils/process.py#L82
- After: https://git.ligo.org/kipp.cannon/python-ligo-lw/-/blob/5faced2e682833caa0165f2a0bbcc7eaea99c4a5/ligo/lw/lsctables.py#L483
It looks like the API was changed during the ligo.lw.utils.process
rework, so that it now takes instruments
rather than the ifos
kwarg:
I wanted to double check that this was intended since this shows up in a number of places in gstlal and may cause some issues unintended issues when it's deployed on SL7. I didn't see this in the changelogs but could have missed it.