GitLab

I have done some successful testing with this file, but it required some fixes to be able to push zpk arrays to foton correctly. I will reference the current master branch.

Firstly, ZPKz_add function:

• https://git.ligo.org/lee-mcculler/iirrational/blob/master/IIRrational/LIGO/foton.py#L522
  • should say zero_list.append(matlab_complex_str(zero))
  • is a fairly clear copy paste bug
• https://git.ligo.org/lee-mcculler/iirrational/blob/master/IIRrational/LIGO/foton.py#L510
  • should say return ("{0}".format(np.real(num)))
  • this gets around pushing numbers with the complex part of the number still appended (eg 101 + j0)

Same bugs used to apply (in older versions) to the function ZPK_add, but I see you have moved functionality to the 'IIRrational/LIGO/conversion.py' , which I have not tested. I can clearly see a similar bug here:

• https://git.ligo.org/lee-mcculler/iirrational/blob/master/IIRrational/LIGO/conversion.py#L108
  • should say return ("{0}".format(np.real(num)))
• The first bug I noted above is present in the commented out code, but it is clear that it isn't present in the rest of the functions