Weird behaviour if mass_2 > mass_1 in injection parameters
In our source model, if mass_2 > mass_1, we return None and there is a check for this in the likelihood.
However, if you set the injection parameters up such that mass_2 > mass_1 (which is quite easily done if you just sample from the prior). Then your waveform_generator will return None and it's not until later on in get_detector_response
when you try it inject signal that it fails.
This is a potential hazard for new users. There are several ways to fix it so I thought I'd make an issue before attempting it myself.
- When injecting a signal, check if it is None and warn the user that this may have happened
- When sampling from the priors have a check that mass_2 > mass_1 - this would be a lot of effort as we'd need a tool that works generally.
What do people think? @all