GW150914 example broken
I get the following error when I run the GW150914.py tutorial:
Traceback (most recent call last):
File “GW150914.py”, line 42, in <module>
‘reference_frequency’: 50})
TypeError: __init__() missing 2 required positional arguments: ‘time_duration’ and ‘sampling_frequency’
This can be solved by changing line 39 of the current script to
waveform_generator = tupak.gw.waveform_generator.WaveformGenerator(
time_duration=interferometers.duration, sampling_frequency=interferometers.sampling_frequency,
frequency_domain_source_model=tupak.gw.source.lal_binary_black_hole,
waveform_arguments={'waveform_approximant': 'IMRPhenomPv2', 'reference_frequency': 50})
This looks a little clunky as we have to pass the interferometers object into the waveform_generator. Is there a cleaner way of doing this? Regardless, we need to update the example.