Discrepancy in definitions of matched filter SNR
On issue #221 (closed), @cjhaster wrote
In
LALInferencethe matched_filter_snr isn't defined assqrt(Re{<d|h>}), but instead asRe{<d|h>}/sqrt(Re{<h|h>}). SeeLALInferencereference here, and in surrounding lines
(I'm opening a new issue as the original issue was a purely programatic error I think).
Should we change the definition in bilby to match that of lalinference?