Waveforms comparison

Demonstrate that, given the same set of parameters bilby and L.I. (perhaps through a proxy of pycbc) return the same waveform.

changed milestone to %0.5.3

added 1 deleted label

Related discussion on how to do this with L.I. https://chat.ligo.org/ligo/pl/idi8iwb6b3boictshn63kd3jdh

Comparison of IMRPhenomPv2 with PyCBC and Bilby - apart from the time shift there is some other weird behaviour

The parameters:

injection_parameters = dict( mass_1=36., mass_2=29., a_1=0.4, a_2=0.3, tilt_1=0.5, tilt_2=1.0, phi_12=1.7, phi_jl=0.3, luminosity_distance=4000., theta_jn=0.4, psi=2.659, phase=1.3, geocent_time=1126259642.413, ra=1.375, dec=0.2108) which have been transformed into iota, spin_1x, spin_1y, spin_1z, spin_2x, spin_2y, spin_2z to pass into PyCBC using the conversion function bilby.gw.conversion.bilby_to_lalsimulation_spins

changed milestone to %0.5.4

changed milestone to %0.5.5

There is a tiny phase difference between PyCBC and Bilby - not sure where its coming from.

@nikhil.sarin could you add some background explanation and the script you are using? These look really close to me.

test.py There was another bug and a problem with the definition of constants - it seems lal and bilby have different definitions of solar mass which maybe causing a difference @colm.talbot. There is now a 2\pi phase difference and the difference in strain is 3 orders of magnitude smaller than the actual waveform.

So the errors at at the 0.1% level? Could you plot the first three figures with just the residual?

Closing as this is resolved: https://git.ligo.org/lscsoft/bilby_pipe/wikis/O3-review/analytic-waveforms

closed

unassigned @nikhil.sarin