Minimum Python version should be 3.6

f string which is used in the package is available since Python 3.6, but the minimum Python version in https://git.ligo.org/lscsoft/bilby/-/blob/master/setup.py is 3.5.

@chun-fung.wong where is the f string used? I've been trying to keep an eye out to avoid them. I think it is a bigger conversation to decide when we should change to 3.6 only.

These lines:

https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/core/sampler/dynesty.py#L634

https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/core/sampler/cpnest.py#L117

Sorry, these were both me. I'd be happy for them to be removed.

created merge request !811 (merged) to address this issue

mentioned in merge request !811 (merged)

In !811 (merged) I've reverted the changes so that we remain 3.5 compatible.

Python 3.5 is EOL in September this year. I'm game for making bilby 3.6+ at any time and I think @bruce.edelman even had a nice method to convert all our string formats to f-strings. My suggestion is to we release 1.0 as 3.5 compatible and then go to 3.6+ for future releases, this way we have a broadly usable reviewed version.

closed via merge request !811 (merged)

mentioned in commit aee04c79