Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
bilby
bilby
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 12
    • Merge Requests 12
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • lscsoft
  • bilbybilby
  • Issues
  • #504

Closed
Open
Opened Jul 13, 2020 by Colm Talbot@colm.talbotMaintainer

Joint distributions difficult to subclass.

I'm trying to subclass the GaussianMixture and GaussianMixtureDist classes and ran into an issue with the way the underlying distribution is checked. I think that this line should be changed to

        if not isinstance(dist, BaseJointPriorDist):

Unless I'm missing something @matthew-pitkin @bruce.edelman, I think you're most familiar with this bit of the code?

EDIT:

I'm now having an issue reading the prior from a standard .prior file. There are specifically enumerated names. We should also look for subclasses.

Edited Jul 13, 2020 by Colm Talbot
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: lscsoft/bilby#504