BUG: Waveform kwargs are silently ignored
Slightly related to #681.
lal_binary_black_hole
(and similar functions in bilby/gw/source.py) silently ignore waveform arguments
if they are written using the wrong convention.
For example, if I were to use
waveform_arguments={"f_min": 10, "f_ref": 10}
the lal_binary_black_hole
function would ignore it, as the actual kwargs are minimum_frequency
and reference_frequency
. As a result, the inputs would become whatever default values are coded
inside the function (in this case 20 and 50).
The reason is because the default values are overwritten using the update
method in a dictionary,
which I would say is not the right tool for this purpose as it doesn't check the validity of the given keys.