How should polarizations be passed around?
Currently, we have two implemented methods to pass polarizations around. Let's agree on one method and stick to it.
A) The source method should return a dictionary of all the polarizations
I think this is what @rory-smith and @sylvia.biscoveanu are assuming in other parts of the code (is that correct?)
class Source:
def model(self, times, parameters):
...
return {'plus': h_plus, 'cross': h_cross}
B) The source method should return a tuple of hplus and hcross
This is how @paul-lasky has written the BinaryBlackHole
source
class Source:
def model(self, times, parameters):
...
return h_plus, h_cross
This is the more natural way to do things, but B A (edited) allows more flexibililty for other modes. It is important to define now exactly what should be returned as many other functions are going to make assumptions about it.
In case A, should we assume there is always at least h_plus and h_cross? Is one enough?
Edited by Gregory Ashton