typo fix in earth light crossing (!1003) · Merge requests · lscsoft / bilby · GitLab

Snippets Groups Projects

Maintenance will be performed on git.ligo.org, containers.ligo.org, and docs.ligo.org on Tuesday 22 April 2025 starting at approximately 9am PDT. It is expected to take around 30 minutes and there will be several periods of downtime throughout the maintenance. Please address any comments, concerns, or questions to the helpdesk. This maintenance will be upgrading the GitLab database in order to be ready for the migration.

Merged Colm Talbot requested to merge typo-fix-light-crossing into master 3 years ago

This MR resolves a small typo in the ROQ likelihood. The light crossing time was half what it should have been, the maximum crossing time is diameter / speed not radius / speed as currently calculated.

This doesn't make a difference when the time reference is the geocentre, but can break when using the reference time at an interferometer.

Approval is optional

Activity

Colm Talbot added Bug Likelihood ROQ labels 3 years ago

added Bug Likelihood ROQ labels
Moritz Huebner changed milestone to %1.1.4 3 years ago

changed milestone to %1.1.4
Matthew Pitkin approved this merge request 3 years ago

approved this merge request
Gregory Ashton approved this merge request 3 years ago

approved this merge request
Gregory Ashton mentioned in commit 13b517b5 3 years ago

mentioned in commit 13b517b5
Gregory Ashton merged 3 years ago

merged

Please register or sign in to reply